ÉèΪÊ×Ò³ ¼ÓÈëÊÕ²Ø

TOP

Code review check list
2014-11-23 21:40:09 À´Ô´: ×÷Õß: ¡¾´ó ÖРС¡¿ ä¯ÀÀ:10´Î
Tags£ºCode review check list

Does the code follow the architecture design(Folder structure,Exception framework,log,error code¡­)
Does the code follows coding standard(the name of variable and method,indent,comment,¡­)
Are assertions used everywhere data is expected to have a valid value or range
Are resources and memory released in all error paths
Are all thrown exceptions handled properly
Is allocated resources (db connections,sockets,files,etc.) freed
Are all global,static and shared variables thread-safe
Are locks released in the same order they are obtained(avoid dead lock)
Are there any complex SQL, are they reasonable
Are function parameters explicitly verified in the code
Are arrays explicitly checked for out-of-bound indexes
Are there any bad smells (duplicate code,¡­)


¡¾´ó ÖРС¡¿¡¾´òÓ¡¡¿ ¡¾·±Ìå¡¿¡¾Í¶¸å¡¿¡¾Êղء¿ ¡¾ÍƼö¡¿¡¾¾Ù±¨¡¿¡¾ÆÀÂÛ¡¿ ¡¾¹Ø±Õ¡¿ ¡¾·µ»Ø¶¥²¿¡¿
·ÖÏíµ½: 
ÉÏһƪ£ºß@ƒÉÌìÏÈáá…¢¼ÓÁËBaiduºÍGoogleÐ.. ÏÂһƪ£ºÓ¦Æ¸Ò»IT¹«Ë¾ÍøÂç¹ÜÀíµÄÃæÊÔÌâ

ÆÀÂÛ

ÕÊ¡¡¡¡ºÅ: ÃÜÂë: (ÐÂÓû§×¢²á)
Ñé Ö¤ Âë:
±í¡¡¡¡Çé:
ÄÚ¡¡¡¡ÈÝ: